Skip to content

fix: 任务窗口速度与取消未对齐#6140

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
CiiLu:emmmmmmm
Jul 16, 2026
Merged

fix: 任务窗口速度与取消未对齐#6140
Glavo merged 1 commit into
HMCL-dev:mainfrom
CiiLu:emmmmmmm

Conversation

@CiiLu

@CiiLu CiiLu commented May 24, 2026

Copy link
Copy Markdown
Contributor
image image

@CiiLu CiiLu changed the title fix: 人物窗口速度与取消未对齐 fix: 任务窗口速度与取消未对齐 May 24, 2026
@Wulian233

Copy link
Copy Markdown
Contributor

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Glavo

Glavo commented May 27, 2026

Copy link
Copy Markdown
Member

/gemini review

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@Glavo

Glavo commented May 27, 2026

Copy link
Copy Markdown
Member

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the layout of the TaskExecutorDialogPane by replacing a BorderPane with an HBox at the bottom of the dialog, cleaning up imports, and using a spacer region to push the cancel button to the right. The review feedback suggests avoiding wildcard imports for javafx.scene.layout to comply with the Google Java Style Guide, and recommends binding the visibility and managed properties of lblProgress to its text content to prevent layout issues when the progress label is empty.

@Glavo

Glavo commented Jul 16, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: f2049028d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Glavo
Glavo merged commit 4b36f8c into HMCL-dev:main Jul 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants